Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added signals support #3

Merged
merged 2 commits into from Feb 19, 2018
Merged

added signals support #3

merged 2 commits into from Feb 19, 2018

Conversation

miki725
Copy link
Contributor

@miki725 miki725 commented Feb 16, 2018

No description provided.

@miki725
added signals support
fb50670 
bumping version to 0.3.0
@coveralls
Copy link

coveralls commented Feb 16, 2018 •
edited

Coverage Status

Coverage remained the same at 100.0% when pulling 6fc115b on signals into 24bcf7a on master.

shosca
shosca reviewed Feb 16, 2018
View reviewed changes
pycontext/signals.py Outdated
from blinker import NamedSignal


context_initialized = NamedSignal('context_initialized')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might wanna use a namespace for these now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/jek/blinker/blob/master/blinker/base.py#L422

@miki725 miki725 merged commit 3f71513 into master Feb 19, 2018
@miki725 miki725 deleted the signals branch February 19, 2018 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shosca shosca shosca left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@miki725 @coveralls @shosca