New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Bug in Which Mapper Can't Map to ListConfig if Input is None #13
Fixed Bug in Which Mapper Can't Map to ListConfig if Input is None #13
Conversation
@miki725, please review and merge. |
@@ -3,4 +3,4 @@ | |||
|
|||
|
|||
__author__ = 'Miroslav Shubernetskiy' | |||
__version__ = '0.3.4' | |||
__version__ = '0.3.5' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you update HISTORY.rst
as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
@miki725: whenever you're ready to re-review and merge. |
HISTORY.rst
Outdated
0.3.5 (2018-06-14) | ||
~~~~~~~~~~~~~~~~~~~~~ | ||
|
||
* Fixed bug in which TypeError would result if a None value were mapped to a ``ListConfig`` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrap TyperError
around double backticks to render as code. same for None
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
@miki725, all changes have been made. |
@miki725: ping. |
Yaissssssssssss! |
Example:
if value of config is the following
And input is
The following error is shown
TypeError: 'NoneType' object is not iterable
This fix just returns an empty list if the input is
None
.