Add MUMPS package (and some dependencies) #246
Conversation
| if [ ! -z "${PARMETIS_DIR}" ]; then | ||
| CONFOPTS="${CONFOPTS} --download-scalapack=1" | ||
| fi |
There was a problem hiding this comment.
Why do we need to check for parmetis?
There was a problem hiding this comment.
I added this check for ParMETIS only because in the PETSc package it checks if ParMETIS is present before installing MUMPS and ScaLAPACK.
See: petsc.package#L76-L87
I have not tested whether this check is necessary, I just assumed that it is necessary because it was already there.
There was a problem hiding this comment.
Ah okay I see, in the original there are the downloads for mumps and scalapack only if parmetis is present without explaining it.
There was a problem hiding this comment.
Anyhow, this looks strange and should be tested if this makes sense.
There was a problem hiding this comment.
Okay, I will test, if ParMETIS is necessary for MUMPS and ScaLAPACK.
There was a problem hiding this comment.
It seems like ParMATIS is not necessary for MUMPS and ScaLAPACK, therefore I removed the check.
| if [ ! -z "${BLAS_DIR}" ]; then | ||
| CONFOPTS="${CONFOPTS} \ | ||
| -D pc_blas_LIBRARY_DIRS=${BLAS_DIR}/lib " | ||
| fi | ||
|
|
||
| if [ ! -z "${BLACS_DIR}" ]; then | ||
| CONFOPTS="${CONFOPTS} \ | ||
| -D MKL_INCLUDE_DIRS=${BLACS_DIR}" | ||
| fi |
There was a problem hiding this comment.
can this be a problem if both, blas and mkl blacs, are given?
There was a problem hiding this comment.
I am not quite sure.
But to be on the safe side, we can set either BLAS only or MKL BLACS only, depending on whether this is an MKL build or not.
There was a problem hiding this comment.
I took a closer look at how to properly link MUMPS to intel MKL and adapted these lines accordingly.
|
|
||
| if [ ! -z "${BLACS_DIR}" ]; then | ||
| CONFOPTS="${CONFOPTS} \ | ||
| -D MKL_INCLUDE_DIRS=${BLACS_DIR}" |
There was a problem hiding this comment.
what happens if we have the standard blacs from netlib and not the mkl?
There was a problem hiding this comment.
This is a good remark!
The installer will not find the BLACS from netlib.
However, it is sufficient when either BLACS or BLAS is present.
| if [ ! -z "${PARMETIS_DIR}" ]; then | ||
| CONFOPTS="${CONFOPTS} --download-mumps=1" | ||
| fi |
There was a problem hiding this comment.
Why do we need to check for parmetis?
There was a problem hiding this comment.
Same answer as above: I have not tested whether this check is necessary, I just assumed that it is necessary because it was already there.
| @@ -104,7 +121,7 @@ package_specific_setup () { | |||
|
|
|||
| package_specific_register () { | |||
| export PETSC_DIR=${INSTALL_PATH} | |||
| if [ ! -z "${PARMETIS_DIR}" ]; then | |||
| if [ ! -z "${PARMETIS_DIR}" ] && [ -z "${SCALAPACK_DIR}" ]; then | |||
There was a problem hiding this comment.
Why do we need to check for parmetis?
There was a problem hiding this comment.
Again the same answer as above: I have not tested whether this check is necessary, I just assumed that it is necessary because it was already there.
| fi | ||
|
|
||
| # Set Fortran flags | ||
| FORTRAN_MAJOR_VERSION=$(echo __GNUC__ | ${FC} -E -xc - | tail -n 1) |
There was a problem hiding this comment.
this works only if FC is given
There was a problem hiding this comment.
I will add a test if FC is given.
But what can we do, when FC is not given? We still need to check the compiler version, since we need to set the Fortran_FLAGS correspondingly.
There was a problem hiding this comment.
Well, than you can't do much, you can try finding gfortran as it is done in candi.sh for tools like wget.
But if FC is however not set, this may end in a strange error
There was a problem hiding this comment.
simply put if [[ -n ${FC} ]] around this statement, this should be good
There was a problem hiding this comment.
I added a test if FC is given.
|
|
||
| package_specific_register () { | ||
| export SCALAPACK_DIR=${INSTALL_PATH} | ||
| export BLACS_DIR=${INSTALL_PATH}/lib |
There was a problem hiding this comment.
is blacs always installed?
There was a problem hiding this comment.
According to the README of ScaLAPACK:
New in version 2.0:
- The BLACS is now part of ScaLAPACK, and is compiled into the ScaLAPACK
library. It is no longer necessary to link against BLACS libraries.
Therefore I assume it is always installed.
There was a problem hiding this comment.
okay, maybe put a comment somewhere such that it is clear that scalapack installs blacs.
I think it can be useful. |
If I remember correctly the trilinos package may have also an interface to MUMPS, which may be interesting to have. |
|
I have only now been able to continue working on the pull request. Nevertheless I checked in the meantime if ParMETIS is necessary to install MUMPS and ScaLAPACK in PETSc. Therefore I installed MUMPS and Scalapack via PETSc (without ParMETIS) and run some tests. As far as I can tell, ParMETIS is not necessary for MUMPS and ScaLAPACK to work with PETSc. Therefore I removed the check if ParMETIS is available.
Yes, Trilinos has an interface to MUMPS and I already linked MUMPS into Trilinos, since I am already using MUMPS via Trilinos in my code. I also took a closer look at the installation of MUMPS with intel MKL and adapted the package accordingly. |
|
On ubuntu 20.04 the check failed because the package libxnvctrl0 could not be installed. |
yes that is unrelated. |
At the moment MUMPS is only available via PETSc, when deal.II was installed through candi.
Since I am using MUMPS via Trilions, I added one package for MUMPS and linked it into PETSc and Trilinos. I also added a package for ScaLAPACK since it is used by PETSc and MUMPS (otherwise, PETSc and MUMPS would each install their own version of ScaLAPACK and we would end up with two different installations of ScaLAPACK).
Is this package for MUMPS of interest for candi?