Skip to content
This repository has been archived by the owner on Sep 18, 2023. It is now read-only.

Validate the whole json during load #122

Merged

Conversation

lode
Copy link
Contributor

@lode lode commented Apr 10, 2019

This is something I found while going through the code, not something that blocks me or so. I thought it would be good to have one place to do validation (instead of spread out between load() and loadMultiple()), and to also include the validation done only later during parse(). That makes that all code can assume valid json.

@deanblackborough deanblackborough changed the base branch from master to v3.17.4 May 1, 2019 11:23
@deanblackborough deanblackborough merged commit bbe4276 into deanblackborough:v3.17.4 May 1, 2019
@deanblackborough
Copy link
Owner

Awesome, thank you.

@lode lode deleted the validate-all-during-load branch May 1, 2019 19:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants