Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NoSqlPlugin for Play needs to allow access to Properties #80

Closed
nadenf opened this issue Apr 27, 2013 · 5 comments
Closed

NoSqlPlugin for Play needs to allow access to Properties #80

nadenf opened this issue Apr 27, 2013 · 5 comments

Comments

@nadenf
Copy link
Contributor

nadenf commented Apr 27, 2013

I am trying to pass in a custom Cassandra builder but I don't have access to the Properties map in order to set it.

Can we modify the NoSqlPlugin to have a global properties map and a getProperties() accessor method ?

@deanhiller
Copy link
Owner

yes, we can easily pull the changes you want in......Also, I have sent vikas an email to do this for you but you may need to wait longer(otherwise 9 times out of 10, he has the pull request done in 24 hours and if not, you have me too ;) and I can get it done). Sorry for the late reply...I saw your post on friday but was leaving work and was a bit lazy that day and off to play.

@deanhiller
Copy link
Owner

so issue a pull request if you want it done quick otherwise vikas will start it around friday after his other issues are resolved

@easility
Copy link
Collaborator

In case you want us to do it on Friday, can you provide few more details:

  1. We have issue Astyanax retry policy is missing as configuration option #32 as well which is related to this. Where you want to put the properties in application.conf along with existing 4 properties and then read them in BootstrapImpl.java
  2. Otherwise, how would you like to have a separate map. Do you want a separate properties file? Or want to add properties in Java file.

@nadenf
Copy link
Contributor Author

nadenf commented Apr 29, 2013

I can provide a pull request for this tomorrow but it's really, really simple. In NoSQLPlugin:

  1. Add global:
    private static final Map<String, Object> props = new HashMap<String, Object>();

  2. Remove:
    Map<String, Object> props = new HashMap<String, Object>();
    from onApplicationStart()

  3. Add:
    public static Map<String, Object> getProperties() {
    return props;
    }

easility added a commit that referenced this issue May 3, 2013
@easility
Copy link
Collaborator

easility commented May 3, 2013

This is done as suggested. Closing

@easility easility closed this as completed May 3, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants