Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

engines: add google lucky search #47

Merged
merged 3 commits into from Oct 2, 2018
Merged

engines: add google lucky search #47

merged 3 commits into from Oct 2, 2018

Conversation

nikitavoloboev
Copy link
Contributor

No description provided.

@nikitavoloboev
Copy link
Contributor Author

Not sure if I need to change anything else. I just search and replaced the query so its the one referenced in #16.

Although entering below in my browser tab search and pressing return

https://www.google.com/search?btnI=I%27m+Feeling+Lucky&q=youtube&hl=ach&safe=off

Doesnt actually do google lucky search.

@deanishe
Copy link
Owner

deanishe commented Oct 2, 2018

Not sure if I need to change anything else

I see you've just noticed it needs a different name to the existing Google search.

You also need to add an icon in src/icons/engines.

@deanishe deanishe merged commit 354a175 into deanishe:develop Oct 2, 2018
@nikitavoloboev
Copy link
Contributor Author

I wanted to squash them into 1 commit for cleaner history. Sorry.

@deanishe
Copy link
Owner

deanishe commented Oct 2, 2018

Doesn't matter.

You only renamed the engine, not the searches. When you add a search, it shows up as "Google (XYZ)", not "Google Lucky (XYZ)".

Can you please test stuff properly before submitting a PR?

@nikitavoloboev
Copy link
Contributor Author

Can you please test stuff properly before submitting a PR?

Didn't see this commit 54b120a

Will do next time.

@deanishe
Copy link
Owner

deanishe commented Oct 2, 2018

What do you mean? That commit should be irrelevant to the PR.

See google-lucky.json in fff4aa4 to see the problem.

@nikitavoloboev
Copy link
Contributor Author

nikitavoloboev commented Oct 2, 2018

What do you mean?

Well I couldn't build the workflow to test it. Because of those variables I mentioned.

@nikitavoloboev
Copy link
Contributor Author

I know I could of spotted it without building the workflow. Was just excited for @deanishe to have my PR merged. 😭

@nikitavoloboev
Copy link
Contributor Author

nikitavoloboev commented Oct 2, 2018

A bit out of topic but I recently started using TaskPaper to dissect problems I am trying to solve. Feel like a different human being now. I know you use it too so thought I'd mention it.

@deanishe
Copy link
Owner

deanishe commented Oct 2, 2018

I know I could of spotted it without building the workflow

Yup, but you noticed that (and that the engine name needed changing), which is the main thing 👍

I recently started using TaskPaper to disect problems I am trying to solve

Out of interest, why? I thought you were a mindmaps guy.

I mostly use TaskPaper because I've never really got used to mindmaps, even though both are essentially just trees.

@nikitavoloboev
Copy link
Contributor Author

nikitavoloboev commented Oct 2, 2018

thought you were a mindmaps guy

I moved mainly because with MindNode, if I was to create a new node, I could not 'Focus in' on it. Unless I zoom out to some secluded part in a mind map. So I only see the main node and the branches.

But now that I tried TaskPaper, it really is incredible. Ability to create projects. Nest as much as I like. Jump between projects with ease. It just flows a lot better and I only just started using it.

I use mind maps for things like this now:

Drawing connections between things. A digital whiteboard. For example mapping the architecture of Learn Anything or some workflow would be nice to do in a visual mind map way. But otherwise TaskPaper is just too good. I am also moving my huge Trello board of things I want to learn (https://trello.com/b/cu32qF3q) to it because I need nesting.

So I can do things like this:

2018-10-02 at 20 34

But on multiple nest level. It's pretty awesome.

@nikitavoloboev
Copy link
Contributor Author

nikitavoloboev commented Oct 2, 2018

Here is my approach to solving problems written out (https://github.com/nikitavoloboev/knowledge/blob/master/research/solving-problems.md). I try to be methodical with everything I do and build processes because I hate unnecessary thinking.

cgxxv pushed a commit to cgxxv/alfred-searchio that referenced this pull request Mar 25, 2022
Engines: add "Google Lucky" search
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants