Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throws error on Gif87a header #10

Closed
sudsy opened this issue May 11, 2015 · 6 comments
Closed

Throws error on Gif87a header #10

sudsy opened this issue May 11, 2015 · 6 comments

Comments

@sudsy
Copy link

sudsy commented May 11, 2015

Hi There,

A program I am using outputs gif87a format files and although your decoder can read them (I think they are a subset of Gif89a) you have a sanity check that makes sure the header is gif 89a. If I get a chance I can fix this and make a PR. Would you like me to do that or fix it yourself.

Ben

@deanm
Copy link
Owner

deanm commented May 11, 2015

Have you tried the change locally? I believe I didn't include 87a because I was unsure of any subtle differences in the specs

@sudsy
Copy link
Author

sudsy commented May 11, 2015

What I did was change the header of my gif to 89a manually and it worked. A
search on Google suggests that 89a is a superset of 87a.

On Mon, 11 May 2015 16:50 Dean McNamee notifications@github.com wrote:

Have you tried the change locally? I believe I didn't include 87a because
I was unsure of any subtle differences in the specs


Reply to this email directly or view it on GitHub
#10 (comment).

@deanm
Copy link
Owner

deanm commented May 11, 2015

3f6bd37

@deanm deanm closed this as completed May 11, 2015
@deanm
Copy link
Owner

deanm commented May 11, 2015

I haven't seen many 87a files, so just curious, which software was outputting 87a?

@deanm
Copy link
Owner

deanm commented May 11, 2015

PS: Published in NPM as omggif@1.0.6

@sudsy
Copy link
Author

sudsy commented May 11, 2015

A tool called Pixen that I found in the Mac App Store.

Thanks so much for the quick fix. I will be publishing a dependent project
tomorrow which takes an animated gig and outputs it to a grid of LED lights.

On Mon, 11 May 2015 18:28 Dean McNamee notifications@github.com wrote:

PS: Published in NPM as omggif@1.0.6


Reply to this email directly or view it on GitHub
#10 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants