Merge pull request #137 from cgunther/brpop-timeout

Fix deprecation of passing timeout as positional argument to brpop
deanpcmad · Aug 23, 2022 · 95f2211 · 95f2211
2 parents 0a33979 + 3147c28
commit 95f2211
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,7 @@
 # Changelog
 
+- #137 - Fix deprecation of passing timeout as positional argument to brpop
+
 ## [4.3.0] - 2022-08-16
 
 - #135 - Some extra fixes for Sidekiq 6.5 (fixes #128, #130, #131) from [@BobbyMcWho](https://github.com/BobbyMcWho)

diff --git a/lib/sidekiq/limit_fetch.rb b/lib/sidekiq/limit_fetch.rb
@@ -70,7 +70,7 @@ def redis_brpop(queues)
       sleep TIMEOUT  # there are no queues to handle, so lets sleep
       []             # and return nothing
     else
-      redis_retryable { Sidekiq.redis { |it| it.brpop *queues, TIMEOUT } }
+      redis_retryable { Sidekiq.redis { |it| it.brpop *queues, timeout: TIMEOUT } }
     end
   end
 end