Rubocop-required changes

To have development dependencies listed in the gemspec, we have to include a rubocop configuration stanza. Remove gem sidekiq from top-level Gemfile as a result of it being in the gemspec. Let appraisal gem remake all the dependent gemfiles for CI.
deanpcmad · Feb 25, 2024 · a0a30dc · a0a30dc
1 parent f01f15e
commit a0a30dc
Show file tree

Hide file tree

Showing 11 changed files with 302 additions and 11 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -28,7 +28,7 @@ jobs:
           - 6379:6379
 
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v4
     - name: Set up Ruby
       uses: ruby/setup-ruby@v1
       with:

diff --git a/.rubocop.yml b/.rubocop.yml
@@ -27,3 +27,8 @@ Naming/VariableNumber:
 Naming/FileName:
   Exclude:
     - lib/sidekiq-limit_fetch.rb
+
+Gemspec/DevelopmentDependencies:
+  EnforcedStyle: gemspec
+  Exclude:
+    - 'demo/*'
diff --git a/Gemfile b/Gemfile
@@ -2,5 +2,3 @@
 
 source 'https://rubygems.org'
 gemspec
-
-gem 'sidekiq'
diff --git a/gemfiles/sidekiq_6.0.gemfile.lock b/gemfiles/sidekiq_6.0.gemfile.lock
@@ -1,7 +1,7 @@
 PATH
   remote: ..
   specs:
-    sidekiq-limit_fetch (4.4.0)
+    sidekiq-limit_fetch (4.4.1)
       sidekiq (>= 6)
 
 GEM
@@ -11,15 +11,27 @@ GEM
       bundler
       rake
       thor (>= 0.14.0)
+    ast (2.4.2)
     connection_pool (2.2.5)
     diff-lcs (1.5.0)
+    docile (1.4.0)
+    json (2.7.1)
+    language_server-protocol (3.17.0.3)
+    parallel (1.24.0)
+    parser (3.3.0.5)
+      ast (~> 2.4.1)
+      racc
+    racc (1.7.3)
     rack (2.2.3.1)
     rack-protection (2.2.0)
       rack
+    rainbow (3.1.1)
     rake (13.0.6)
     redis (4.6.0)
     redis-namespace (1.8.2)
       redis (>= 3.0.4)
+    regexp_parser (2.9.0)
+    rexml (3.2.6)
     rspec (3.11.0)
       rspec-core (~> 3.11.0)
       rspec-expectations (~> 3.11.0)
@@ -33,23 +45,47 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.11.0)
     rspec-support (3.11.0)
+    rubocop (1.60.2)
+      json (~> 2.3)
+      language_server-protocol (>= 3.17.0)
+      parallel (~> 1.10)
+      parser (>= 3.3.0.2)
+      rainbow (>= 2.2.2, < 4.0)
+      regexp_parser (>= 1.8, < 3.0)
+      rexml (>= 3.2.5, < 4.0)
+      rubocop-ast (>= 1.30.0, < 2.0)
+      ruby-progressbar (~> 1.7)
+      unicode-display_width (>= 2.4.0, < 3.0)
+    rubocop-ast (1.30.0)
+      parser (>= 3.2.1.0)
+    ruby-progressbar (1.13.0)
     sidekiq (6.0.7)
       connection_pool (>= 2.2.2)
       rack (~> 2.0)
       rack-protection (>= 2.0.0)
       redis (>= 4.1.0)
+    simplecov (0.22.0)
+      docile (~> 1.1)
+      simplecov-html (~> 0.11)
+      simplecov_json_formatter (~> 0.1)
+    simplecov-html (0.12.3)
+    simplecov_json_formatter (0.1.4)
     thor (1.2.1)
+    unicode-display_width (2.5.0)
 
 PLATFORMS
+  arm64-darwin-23
   x86_64-linux
 
 DEPENDENCIES
   appraisal
   rake
   redis-namespace (~> 1.5, >= 1.5.2)
   rspec
+  rubocop
   sidekiq (~> 6.0.0)
   sidekiq-limit_fetch!
+  simplecov
 
 BUNDLED WITH
    2.3.5
diff --git a/gemfiles/sidekiq_6.1.gemfile.lock b/gemfiles/sidekiq_6.1.gemfile.lock
@@ -1,7 +1,7 @@
 PATH
   remote: ..
   specs:
-    sidekiq-limit_fetch (4.4.0)
+    sidekiq-limit_fetch (4.4.1)
       sidekiq (>= 6)
 
 GEM
@@ -11,13 +11,25 @@ GEM
       bundler
       rake
       thor (>= 0.14.0)
+    ast (2.4.2)
     connection_pool (2.2.5)
     diff-lcs (1.5.0)
+    docile (1.4.0)
+    json (2.7.1)
+    language_server-protocol (3.17.0.3)
+    parallel (1.24.0)
+    parser (3.3.0.5)
+      ast (~> 2.4.1)
+      racc
+    racc (1.7.3)
     rack (2.2.3.1)
+    rainbow (3.1.1)
     rake (13.0.6)
     redis (4.6.0)
     redis-namespace (1.8.2)
       redis (>= 3.0.4)
+    regexp_parser (2.9.0)
+    rexml (3.2.6)
     rspec (3.11.0)
       rspec-core (~> 3.11.0)
       rspec-expectations (~> 3.11.0)
@@ -31,22 +43,46 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.11.0)
     rspec-support (3.11.0)
+    rubocop (1.60.2)
+      json (~> 2.3)
+      language_server-protocol (>= 3.17.0)
+      parallel (~> 1.10)
+      parser (>= 3.3.0.2)
+      rainbow (>= 2.2.2, < 4.0)
+      regexp_parser (>= 1.8, < 3.0)
+      rexml (>= 3.2.5, < 4.0)
+      rubocop-ast (>= 1.30.0, < 2.0)
+      ruby-progressbar (~> 1.7)
+      unicode-display_width (>= 2.4.0, < 3.0)
+    rubocop-ast (1.30.0)
+      parser (>= 3.2.1.0)
+    ruby-progressbar (1.13.0)
     sidekiq (6.1.3)
       connection_pool (>= 2.2.2)
       rack (~> 2.0)
       redis (>= 4.2.0)
+    simplecov (0.22.0)
+      docile (~> 1.1)
+      simplecov-html (~> 0.11)
+      simplecov_json_formatter (~> 0.1)
+    simplecov-html (0.12.3)
+    simplecov_json_formatter (0.1.4)
     thor (1.2.1)
+    unicode-display_width (2.5.0)
 
 PLATFORMS
+  arm64-darwin-23
   x86_64-linux
 
 DEPENDENCIES
   appraisal
   rake
   redis-namespace (~> 1.5, >= 1.5.2)
   rspec
+  rubocop
   sidekiq (~> 6.1.0)
   sidekiq-limit_fetch!
+  simplecov
 
 BUNDLED WITH
    2.3.5
diff --git a/gemfiles/sidekiq_6.2.gemfile.lock b/gemfiles/sidekiq_6.2.gemfile.lock
@@ -1,7 +1,7 @@
 PATH
   remote: ..
   specs:
-    sidekiq-limit_fetch (4.4.0)
+    sidekiq-limit_fetch (4.4.1)
       sidekiq (>= 6)
 
 GEM
@@ -11,13 +11,25 @@ GEM
       bundler
       rake
       thor (>= 0.14.0)
+    ast (2.4.2)
     connection_pool (2.2.5)
     diff-lcs (1.5.0)
+    docile (1.4.0)
+    json (2.7.1)
+    language_server-protocol (3.17.0.3)
+    parallel (1.24.0)
+    parser (3.3.0.5)
+      ast (~> 2.4.1)
+      racc
+    racc (1.7.3)
     rack (2.2.3.1)
+    rainbow (3.1.1)
     rake (13.0.6)
     redis (4.6.0)
     redis-namespace (1.8.2)
       redis (>= 3.0.4)
+    regexp_parser (2.9.0)
+    rexml (3.2.6)
     rspec (3.11.0)
       rspec-core (~> 3.11.0)
       rspec-expectations (~> 3.11.0)
@@ -31,22 +43,46 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.11.0)
     rspec-support (3.11.0)
+    rubocop (1.60.2)
+      json (~> 2.3)
+      language_server-protocol (>= 3.17.0)
+      parallel (~> 1.10)
+      parser (>= 3.3.0.2)
+      rainbow (>= 2.2.2, < 4.0)
+      regexp_parser (>= 1.8, < 3.0)
+      rexml (>= 3.2.5, < 4.0)
+      rubocop-ast (>= 1.30.0, < 2.0)
+      ruby-progressbar (~> 1.7)
+      unicode-display_width (>= 2.4.0, < 3.0)
+    rubocop-ast (1.30.0)
+      parser (>= 3.2.1.0)
+    ruby-progressbar (1.13.0)
     sidekiq (6.2.2)
       connection_pool (>= 2.2.2)
       rack (~> 2.0)
       redis (>= 4.2.0)
+    simplecov (0.22.0)
+      docile (~> 1.1)
+      simplecov-html (~> 0.11)
+      simplecov_json_formatter (~> 0.1)
+    simplecov-html (0.12.3)
+    simplecov_json_formatter (0.1.4)
     thor (1.2.1)
+    unicode-display_width (2.5.0)
 
 PLATFORMS
+  arm64-darwin-23
   x86_64-linux
 
 DEPENDENCIES
   appraisal
   rake
   redis-namespace (~> 1.5, >= 1.5.2)
   rspec
+  rubocop
   sidekiq (~> 6.2.0)
   sidekiq-limit_fetch!
+  simplecov
 
 BUNDLED WITH
    2.3.5
diff --git a/gemfiles/sidekiq_6.3.gemfile.lock b/gemfiles/sidekiq_6.3.gemfile.lock
@@ -1,7 +1,7 @@
 PATH
   remote: ..
   specs:
-    sidekiq-limit_fetch (4.4.0)
+    sidekiq-limit_fetch (4.4.1)
       sidekiq (>= 6)
 
 GEM
@@ -11,13 +11,25 @@ GEM
       bundler
       rake
       thor (>= 0.14.0)
+    ast (2.4.2)
     connection_pool (2.2.5)
     diff-lcs (1.5.0)
+    docile (1.4.0)
+    json (2.7.1)
+    language_server-protocol (3.17.0.3)
+    parallel (1.24.0)
+    parser (3.3.0.5)
+      ast (~> 2.4.1)
+      racc
+    racc (1.7.3)
     rack (2.2.3.1)
+    rainbow (3.1.1)
     rake (13.0.6)
     redis (4.6.0)
     redis-namespace (1.8.2)
       redis (>= 3.0.4)
+    regexp_parser (2.9.0)
+    rexml (3.2.6)
     rspec (3.11.0)
       rspec-core (~> 3.11.0)
       rspec-expectations (~> 3.11.0)
@@ -31,22 +43,46 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.11.0)
     rspec-support (3.11.0)
+    rubocop (1.60.2)
+      json (~> 2.3)
+      language_server-protocol (>= 3.17.0)
+      parallel (~> 1.10)
+      parser (>= 3.3.0.2)
+      rainbow (>= 2.2.2, < 4.0)
+      regexp_parser (>= 1.8, < 3.0)
+      rexml (>= 3.2.5, < 4.0)
+      rubocop-ast (>= 1.30.0, < 2.0)
+      ruby-progressbar (~> 1.7)
+      unicode-display_width (>= 2.4.0, < 3.0)
+    rubocop-ast (1.30.0)
+      parser (>= 3.2.1.0)
+    ruby-progressbar (1.13.0)
     sidekiq (6.3.1)
       connection_pool (>= 2.2.2)
       rack (~> 2.0)
       redis (>= 4.2.0)
+    simplecov (0.22.0)
+      docile (~> 1.1)
+      simplecov-html (~> 0.11)
+      simplecov_json_formatter (~> 0.1)
+    simplecov-html (0.12.3)
+    simplecov_json_formatter (0.1.4)
     thor (1.2.1)
+    unicode-display_width (2.5.0)
 
 PLATFORMS
+  arm64-darwin-23
   x86_64-linux
 
 DEPENDENCIES
   appraisal
   rake
   redis-namespace (~> 1.5, >= 1.5.2)
   rspec
+  rubocop
   sidekiq (~> 6.3.0)
   sidekiq-limit_fetch!
+  simplecov
 
 BUNDLED WITH
    2.3.5