Honor existing deployed limits #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a cluster with auto-scaling sidekiq servers, a new server entering the pool runs Queues.start, which looks at the config file and sets the limit and process_limit values accordingly. However, if at runtime these values have been changed dynamically for any reason, this overwrites the values with what is in the config file, or removes the limits if there are none in the config file. This is unexpected behavior. Instead, at startup, honor the values found in redis if any are present. Only set the values if none are present in redis.
matt-domsch-sp
force-pushed
the
honor-limit-at-startup
branch
from
3ad2c8d
to
d946dc3
Compare
|
This requires #160 to get merged first so CI passes. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a cluster with auto-scaling sidekiq servers, a new server entering the pool runs Queues.start, which looks at the config file and sets the limit and process_limit values accordingly. However, if at runtime these values have been changed dynamically for any reason, this overwrites the values with what is in the config file, or removes the limits if there are none in the config file. This is unexpected behavior.
Instead, at startup, honor the values found in redis if any are present. Only set the values if none are present in redis.