Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update OffenseRecordRow description regex #50

Merged
merged 1 commit into from
Apr 13, 2021
Merged

update OffenseRecordRow description regex #50

merged 1 commit into from
Apr 13, 2021

Conversation

nthall
Copy link
Contributor

@nthall nthall commented Apr 9, 2021 

It now mirrors the pattern in OffenseRecordRowWithNumber.

fixes #41

@nthall
update OffenseRecordRow description regex
2388739 
    It now matches the regex in OffenseRecordRowWithNumber.
@robert-w-gries
Copy link
Contributor

Looks good to me, but I'll let @copelco review it since he created the original ticket and has more context. Might have to review it on Tuesday depending on availability.

Note for @copelco, should we apply this same change to the law group of the regex? I'm wondering if we're being too restrictive with the whitelisted characters

@robert-w-gries robert-w-gries merged commit 927cb89 into deardurham:main Apr 13, 2021
@robert-w-gries robert-w-gries mentioned this pull request Apr 13, 2021
Closed
1 task
@nthall nthall deleted the parse_slashes_in_offense branch April 14, 2021 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robert-w-gries robert-w-gries robert-w-gries approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OffenseRecordRow parser skips rows with descriptions containing slashes
2 participants
@nthall @robert-w-gries