Fix http 500 error: Don't assume accept header exists #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any client that don't send the accept header in its request will crash this module and produce a http 500 error from VSF.
The problem is the code assumes ´request.headers.accept` exists when trying to find out if the client accepts wepb images.
I found the error when checking the VSF error log on prod server so apparently this is a real issue. Maybe it's just bots and crawlers but this should still be fixed.
I added a "guard" that assumes non-webp support if request.headers.accept doesn't exist.
This PR was tested succesfully using Requestly (Chrome addon).