Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pressing browser back after opening a puzzle causes an error about a deleted sheet #2162

Closed
jpd236 opened this issue May 25, 2024 · 0 comments · Fixed by #2183
Closed

Pressing browser back after opening a puzzle causes an error about a deleted sheet #2162

jpd236 opened this issue May 25, 2024 · 0 comments · Fixed by #2183

Comments

@jpd236
Copy link
Contributor

jpd236 commented May 25, 2024

  1. Open a puzzle page
  2. Hit browser back

Expected: Goes back to puzzle list

Actual: Notification shows up in the sheet:

"Cannot open the link because the linked sheet is deleted."

Hitting back again goes back to the list as expected.
jpd236 added a commit to jpd236/jolly-roger that referenced this issue Jun 19, 2024
@jpd236
Fix browser back on puzzle pages.
f5d84ad 
For some reason, when a Sheets URL is loaded with ?...#gid=0, it
redirects to ?...&gid=0#gid=0; this redirect puts a spurious entry in
the navigation history, which breaks the first back button press.
Embedding the final URL fixes the back button.

Fixes deathandmayhem#2162
jpd236 added a commit to jpd236/jolly-roger that referenced this issue Jun 19, 2024
@jpd236
Fix browser back on puzzle pages.
687e7b0 
For some reason, when a Sheets URL is loaded with ?...#gid=0, it
redirects to ?...&gid=0#gid=0; this redirect puts a spurious entry in
the navigation history, which breaks the first back button press.
Embedding the final URL fixes the back button.

Fixes deathandmayhem#2162
@jpd236 jpd236 mentioned this issue Jun 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix browser back on puzzle pages. jpd236/jolly-roger
1 participant
@jpd236