Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use jupyterlab-fonts for style #24

Merged
merged 25 commits into from
Oct 25, 2022
Merged

Conversation

bollwyvl
Copy link
Contributor

@bollwyvl bollwyvl commented Oct 24, 2022

References

Changes

  • make jupyterlab-fonts a python and JS dependency
  • replace home-grown style with jupyterlab-fonts
  • add a UI for configuring presentation style
  • docs
  • tests

Notes

The JSON (and what it generates) is a bit convoluted:

   "metadata": {
    "@deathbeds/jupyterlab-fonts": {
     "styles": {
      "": {
       "body[data-jp-deck-mode='presenting'] &": {
        "bottom": 0,
        "left": 0,
        "margin": "auto",
        "opacity": "0.25",
        "pointer-events": "none",
        "right": 0,
        "top": 0,
        "width": "50%",
        "z-index": -1
       }
      }
     }
    },
body[data-jp-deck-mode='presenting'] .jp-NotebookPanel[id='id-a91b8119-872c-4d8c-af12-6e33a70d27b5'] .jp-Cell[data-jpf-cell-id="43e53706-854f-466c-a233-050a430e7f84"]  {
  top: 0;
  left: 0;
  right: 0;
  width: 50%;
  bottom: 0;
  margin: auto;
  opacity: 0.25;
  z-index: -1;
  pointer-events: none;
}

@codecov
Copy link

codecov bot commented Oct 24, 2022

Codecov Report

Merging #24 (6c4ae67) into main (18e6601) will decrease coverage by 5.04%.
The diff coverage is 64.81%.

❗ Current head 6c4ae67 differs from pull request most recent head 044335c. Consider uploading reports for the commit 044335c to get more accurate results

@@            Coverage Diff             @@
##             main      #24      +/-   ##
==========================================
- Coverage   94.06%   89.02%   -5.05%     
==========================================
  Files          11       11              
  Lines         674      756      +82     
  Branches      128      146      +18     
==========================================
+ Hits          634      673      +39     
- Misses         22       57      +35     
- Partials       18       26       +8     
Flag Coverage Δ
back-end 100.00% <ø> (ø)
front-end 88.75% <64.81%> (-5.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
js/jupyterlab-deck/src/plugin.ts 100.00% <ø> (ø)
js/jupyterlab-deck/src/notebook/presenter.ts 86.39% <28.57%> (-7.50%) ⬇️
js/jupyterlab-deck/src/remote.tsx 81.25% <33.33%> (-4.96%) ⬇️
js/jupyterlab-deck/src/manager.ts 87.75% <68.42%> (-4.43%) ⬇️
js/jupyterlab-deck/src/notebook/decktools.tsx 92.39% <88.88%> (-3.36%) ⬇️
js/jupyterlab-deck/src/tokens.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bollwyvl bollwyvl marked this pull request as ready for review October 25, 2022 07:18
@bollwyvl bollwyvl merged commit a272e70 into deathbeds:main Oct 25, 2022
@bollwyvl bollwyvl deleted the gh-15-style-ui branch October 25, 2022 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant