Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Slide Layout Tool #28

Merged
merged 29 commits into from
Oct 31, 2022
Merged

Conversation

bollwyvl
Copy link
Contributor

@bollwyvl bollwyvl commented Oct 29, 2022

References

Changes

  • adds design tools in bottom right
    • toggle layout overlay
    • slide type
    • layer type
  • adds slide layout overlay
    • drag for move
    • handles for resize
    • z-index?
    • zoom?
    • opacity?
  • tests

@codecov
Copy link

codecov bot commented Oct 29, 2022

Codecov Report

Merging #28 (8cc03b9) into main (effae0b) will increase coverage by 1.58%.
The diff coverage is 89.33%.

@@            Coverage Diff             @@
##             main      #28      +/-   ##
==========================================
+ Coverage   89.02%   90.60%   +1.58%     
==========================================
  Files          11       13       +2     
  Lines         756     1139     +383     
  Branches      146      229      +83     
==========================================
+ Hits          673     1032     +359     
- Misses         57       66       +9     
- Partials       26       41      +15     
Flag Coverage Δ
back-end 100.00% <ø> (ø)
front-end 90.45% <89.33%> (+1.70%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
js/jupyterlab-deck/src/notebook/presenter.ts 88.99% <76.82%> (+2.60%) ⬆️
js/jupyterlab-deck/src/manager.ts 85.60% <80.72%> (-2.16%) ⬇️
js/jupyterlab-deck/src/notebook/metadata.tsx 92.22% <92.30%> (ø)
js/jupyterlab-deck/src/tools/design.tsx 93.54% <93.54%> (ø)
js/jupyterlab-deck/src/tools/layover.ts 95.34% <95.34%> (ø)
js/jupyterlab-deck/src/icons.ts 100.00% <100.00%> (ø)
js/jupyterlab-deck/src/plugin.ts 100.00% <100.00%> (ø)
js/jupyterlab-deck/src/tokens.ts 100.00% <100.00%> (ø)
js/jupyterlab-deck/src/tools/remote.tsx 82.85% <100.00%> (ø)
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bollwyvl bollwyvl marked this pull request as ready for review October 31, 2022 00:28
@bollwyvl bollwyvl merged commit 7ce1cf6 into deathbeds:main Oct 31, 2022
@bollwyvl bollwyvl deleted the gh-27-drag-drop-wxyzzh branch October 31, 2022 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable basic drag-and-drop organization of cells on slides
1 participant