Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Notebook 7 functionality and testing #59

Merged
merged 11 commits into from
Dec 12, 2023

Conversation

bollwyvl
Copy link
Contributor

@bollwyvl bollwyvl commented Nov 5, 2023

Checklist

  • ran doit lint locally

References

Code changes

  • improve handling of markdown preview
    • open preview as deck if a markdown editor is opened
    • fix live updating CSS jank, hide menus, etc.
  • update acceptance tests
    • markdown preview

User-facing changes

  • markdown documents will get a deck toolbar button
  • starting a deck will start the preview
  • the "sidebar" can then be expanded to hide the source
before default split wide
image image image

Backwards-incompatible changes

  • ??

Future Work

  • sync scrolling???
  • determine if some DOM-based pattern can be used for subslides, e.g.
    <!-- maybe a future front-matter slide -->
    ---
    # The First Thing
    
    ---
    ---
    
    ## A sub-thing
    
    ---
    ---
    
    <!-- this sub-thing intentionally left blank -->
    
    ---
    
    # The Next Thing
    
    

Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (cb67d32) 93.75% compared to head (b5edad2) 93.14%.

Files Patch % Lines
js/jupyterlab-deck/src/markdown/presenter.ts 92.68% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #59      +/-   ##
==========================================
- Coverage   93.75%   93.14%   -0.62%     
==========================================
  Files          15       16       +1     
  Lines        1282     1327      +45     
  Branches      264      274      +10     
==========================================
+ Hits         1202     1236      +34     
- Misses         39       46       +7     
- Partials       41       45       +4     
Flag Coverage Δ
front-end 93.09% <94.91%> (-0.63%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bollwyvl bollwyvl marked this pull request as ready for review December 12, 2023 02:43
@bollwyvl bollwyvl merged commit c7882ea into deathbeds:main Dec 12, 2023
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expand Notebook 7 acceptance tests
1 participant