Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove version file from vcs #63

Merged
merged 1 commit into from
Nov 27, 2021
Merged

Conversation

pmeier
Copy link
Contributor

@pmeier pmeier commented Nov 26, 2021

Let's follow this advice 馃槢

# don't change, don't track in version control

The problem is that setuptools_scm will only use the tag as version if the git HEAD is exactly at the tag and the tree is not dirty, i.e. no local changes. The first is fine in this CI run, but the second is violated. By building again, we change the content of src/pidgy/_version.py and thus we have local changes.

There is a easy remedy: delete the file from tracking and ignore it in the future. Now, every time we reinstall this file changes, but this will not make the git tree dirty.

@tonyfast tonyfast merged commit 12a47c5 into deathbeds:main Nov 27, 2021
@tonyfast
Copy link
Member

thanks for catching this mistake and informing me of the proper way to use this!

@pmeier pmeier deleted the fix-versioning branch March 13, 2022 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants