Skip to content

Commit

Permalink
State move to minecraft-data
Browse files Browse the repository at this point in the history 
#19 (comment)
  • Loading branch information
@deathcap
deathcap committed Jan 12, 2016
1 parent 41abe97 commit 2fbfd59
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion minecraft-protocol-stream.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,9 @@
var Client = require('minecraft-protocol').Client;
var protocol = require('minecraft-protocol');
var assert = require('assert');
var states = protocol.states;
var mcversion = require('./mcversion.js');
var minecraft_data = require('minecraft-data')(mcversion);
var states = minecraft_data.protocol.states;

module.exports = {
protocol: protocol,
Expand Down

2 comments on commit 2fbfd59

@rom1504
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, it's still there https://github.com/PrismarineJS/node-minecraft-protocol/blob/master/src/index.js#L12

(see PrismarineJS/node-minecraft-protocol#258 though)

@deathcap
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rom1504 aha, it's in node-minecraft-protocol index.js but not browser.js which currently only has Client and supportedVersions: https://github.com/PrismarineJS/node-minecraft-protocol/blob/master/src/browser.js

I guess browser.js should be updated to add states, but I'm not sure what else if anything should be added to browser.js from index.js

update: added all but createServer/Client, PrismarineJS/node-minecraft-protocol#314

Please sign in to comment.