Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚡ Feature: Generic tree and visitation framework #17

Merged
merged 59 commits into from
May 4, 2024
Merged

⚡ Feature: Generic tree and visitation framework #17

merged 59 commits into from
May 4, 2024

Conversation

deavmi
Copy link
Owner

@deavmi deavmi commented Apr 13, 2024 •
edited

Purpose ✍️

Implement Tree and VisitationTree.

Todo

  • Update README.md
  • Documentation
  • Implementation
  • Testing

@deavmi
Tree
34d2b30 
- WIP
@deavmi deavmi self-assigned this Apr 13, 2024
@deavmi deavmi changed the title Tree ⚡ Feature: Generic tree and visitation framework Apr 13, 2024
@deavmi
Tree
60028a3 
- Added initial dfs
@deavmi
Tree
84f1840 
- By default use the `always` strat
@deavmi
Tree
4ecb57d 
- Added a TODO
@deavmi
Tree
d5b00c5 
- Added ability to append

Tree (unittests)

- Updated unittests to test appending
@deavmi
InclusionStratergy
f49ecf1 
- Now uses the `TreeNode!(T)` instead of the `T` itself
@deavmi
VisitationTree
167c2b7 
- Working on a visitation tree implementation
@deavmi
Tree
04edc24 
- Pass in, explcitly, the touch startergy
@deavmi
Tree
ce78102 
- Correct visitation stratergy
@deavmi
VisitationTree (unittests)
e44caf3 
- Added missing assertions
@deavmi
Tree (unittests)
838ddbb 
- Added missing assertions
@deavmi
Methods
41ebad0 
- Added rightward shifting mechanism
@deavmi
Methods
11fd2f8 
- Added leftwards shifting mechanism
@deavmi
TreeNode
4a431c4 
- Added removal
- Added indexing support
@deavmi
Tree
8dca2eb 
- Reworking opSlicwe
@deavmi
Tree
d7a830f 
- opSlice done
@deavmi
Tree
54b66ec 
- Added normal opSlice as well
@deavmi
Tree (unittests)
450d811 
- Updated test for parametwerized opSlice
@deavmi
Tree
04c5373 
- Added opIndex
@deavmi
Tree
d3eec6e 
- Cleaned up
- Removed `getValue()`

Tree (unittests)

- Added test for `removeNode(Tree!(T))`
@deavmi deavmi added documentation Improvements or additions to documentation enhancement New feature or request labels Apr 27, 2024
@deavmi
Merge branch 'master' into feature/tree
eeb1fd4
@deavmi
Containers
38169bb 
- Added `shiftIntoLeftwards` and `shiftIntoRightwards`
@deavmi
Containers (unittests)
5b20501 
- Use new methods
@deavmi
Containers
9d39cc3 
- Cleaned up
@deavmi
InclusionStratergy
b1f2cb5 
- Documented

TouchStratergy

- Documented
@deavmi
Containers
457f876 
- Documented method
@deavmi
Copy link
Owner Author

deavmi commented May 2, 2024

Added some more docs, will finish on the weekend

deavmi added 12 commits May 2, 2024 22:40
@deavmi
Tree
5f66b99 
- Documented
- Cleaned
@deavmi
Always(T)
236d857 
- Documented
@deavmi
Tree
92d753f 
- Added `opDollar()` and `@property`'d `length()`
@deavmi
Tree
83c3894 
- Adde doc
@deavmi
Tree
fb61d42 
- Renamed `Tree!(T)` to `Graph!(T)`
@deavmi
Graph
293e396 
- Typo fix
@deavmi
Graph
a448fe3 
- Clean up
@deavmi
Graph
c8eacc7 
- Renamed
@deavmi
Graph
b83cadc 
- Documented helper methods
@deavmi
Graph
6b91fb0 
- Typo fix
@deavmi
graph
c3287bf 
-  Documented `dfs(...)`
@deavmi
Graph
0525bfb 
-  Documented `toString()`
@deavmi
Copy link
Owner Author

deavmi commented May 4, 2024

The implementation seems completed to me ✔️

deavmi added 4 commits May 4, 2024 10:42
@deavmi
Graph (unittests)
9610689 
- Added tests for `opIndex(size_t)`
@deavmi
Graph
1ebed93 
- Implemented `getValue()`

Graph (unittests)

- Added tests for `getValue()`
@deavmi
Graph (unittests)
f1c4631 
- Added test for `opDollar()`
@deavmi
README
82a9978 
- Updated docs
@deavmi
Copy link
Owner Author

deavmi commented May 4, 2024

All done

@deavmi
Copy link
Owner Author

deavmi commented May 4, 2024

Merged ✔️

@deavmi deavmi merged commit 1a754cf into master May 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@deavmi deavmi

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@deavmi