Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚡ Feature: Buffer views #22

Open
wants to merge 36 commits into
base: master
Choose a base branch
from
Open

⚡ Feature: Buffer views #22

wants to merge 36 commits into from

Conversation

deavmi
Copy link
Owner

@deavmi deavmi commented Apr 30, 2024 •
edited

Purpose ✍️

Implement views.

Todo

  • Update README.md
  • Documentation
  • Implementation
  • Testing

@deavmi
View
68d5104 
- Initial work-in-progress for a new `View` type-buffer
@deavmi
View (unittests)
0fb11d7 
- Fixed incorrect assertion
@deavmi
View
dba6ea5 
- Implemented `opSlice()`

View (unittests)

- Added test for `opSlice()`
@deavmi deavmi added documentation Improvements or additions to documentation enhancement New feature or request labels Apr 30, 2024
@deavmi deavmi self-assigned this Apr 30, 2024
@deavmi
View (unittests)
451fb66 
- Added test for out-of-bounds indexing
@deavmi
View
71257f3 
- Added support for the `~=` operator overload

View (unittests)

- Use the operator overload
@deavmi
View
20c3969 
- Allow updating indices
@deavmi
View
b383cfa 
- More work being done on deciding various parts of this API
- Fixed the `opIndexAssign(...)`
@deavmi
View
328239c 
- made `opIndex(size_t)` and `opIndexAssign(T, size_t)` respect the "fake" size

View (unittests)

- Added code to test the above updates to the `View` type
@deavmi
View
df52dab 
- Made `add(T[])` private
@deavmi
Merge branch 'master' into feature/views
a2fc15a
@deavmi
View
2ecb371 
- Added range `opSlice()`
@deavmi
View
bfa7c60 
- Fixed range-based `opSlice(...)`

View (unittests)

- Added unittest
@deavmi
View
64ba0ba 
- New, more efficient `opSlice(size_t, size_t)` implemented

View (unittests)

- Updated slicing tests
@deavmi
View
1b1cb8f 
- Typo fix
@deavmi
View (unittests)
515d85e 
- Added another test to test the last )untested) branch of the `opSlice(size_t, size_t)` method
@deavmi
View (unittests)
6372f2d 
- Added more tests for `opSlice(size_t, size_t)`
@deavmi
View
c886ba1 
- `opSlice()` now forwards to `opSlice(size_t, size_t)`
@deavmi
View
19a7ce6 
- Only add debug in unittest mode
@deavmi
View
e9cb3a1 
- Cleaned up
@deavmi
View
85580d2 
- Cleaned up
@deavmi
View
9472cb9 
- When calling `opSlice(size_t, size_t)` with arguments that are equal then you should return `[]`. This fixe a bug when we do `view[]` and length was `0` as `opSlice()` calls `opSlice(size_t, size_t)` with `opSlice(0, 0) then
@deavmi
View
365d15d 
- Removed unreachable code
@deavmi
View
a421b40 
- Removed unreachable code
@deavmi
View
98f2f10 
- Replaced unreachable code with a false assertion
@deavmi
View
818a7ca 
- Cleaned up
@deavmi
View
f71286e 
- Cleaned up
@deavmi
SectorType
20cb74d 
- Working on type definition
deavmi added 9 commits May 2, 2024 15:49
@deavmi
SectorType
ba4dbd9 
- More compile-time checks added
@deavmi
SectorType
f84f9ca 
- More compile-time checks added
@deavmi
SectorType
d0ea226 
- More compile-time checks added
@deavmi
SectorType
620175d 
- More compile-time checks added
@deavmi
View
1da8936 
- Added docs
@deavmi
View
e841283 
- Cleaned up
@deavmi
View
de77bb7 
- `add(T[])` was constructing TWO `SectorType` instances, make it only one
@deavmi
Merge branch 'master' into feature/views
81f5fb2
@deavmi
niknaks.containers
1bdce71 
- Added graphing back
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@deavmi deavmi

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@deavmi