Notification to application when redis server is down

[kelaneren]

When redis server is down, PubSub throws RedisConnectionException which crashes Consumer. There is no way for application to handle it, trigger recovery or do something. A graceful handling could be considered there, like listener for application so that application can do something.

[debasishg]

Thanks for the feedback. Let me consider some strategy ..

[kelaneren]

Currently I am doing a quick fix. I add a message type E and a try-catch in Consumer run method. If an exception is caught there, fn (the callback function) will send message type E through the callback function. With this change, I only need add E in callback along with S, U, M to deal with redis-server exceptional case. If this solution sounds good to you, I could send you my patch. Also looking forward to hearing better solution

[debasishg]

Your solution sounds good to me. Will u pls send me a pull request w/ the impl and (preferably) a test case ?

[kelaneren]

I have sent my pull request. I checked test folder but I am not clear how the current tests are written. need more time to get more familiar with test source code. Therefore I only added my impl and updated PubSubSpec.

[debasishg]

Thanks a ton. I will do the necessary merge to incorporate the pull request.

[debasishg]

BTW I see you included changes in project.properties & project file also as part of the pull request. Possibly they were specific to your fork ?

[kelaneren]

yes, I am new to github and don't know how to exclude that commit in pull request. please ignore that commit. sorry about it.

[debasishg]

cool .. I will do a manual merge .. Thanks for the pull request ..