ghc/fs_impl.hpp is missing from ext in the 2.4.0 release tarball

[simotek]

What happened?

I tried to compile 2.4.0 on openSUSE tumbleweed and hit the following error

[    9s] /home/abuild/rpmbuild/BUILD/barrier-2.4.0/src/lib/io/filesystem.cpp:19:10: fatal error: ghc/fs_impl.hpp: No such file or directory
[    9s]    19 | #include <ghc/fs_impl.hpp>
[    9s]       |          ^~~~~~~~~~~~~~~~~

On further inspection of the tarball the following directories are empty ext/gmock ext/gtest ext/gulrak-filesystem

The tarball was downloaded from https://github.com/debauchee/barrier/archive/v2.4.0/barrier-2.4.0.tar.gz

As a side note you need to add 2.3.4 and 2.4.0 to the version drop down in the bug report form

Version

From Git HEAD or commit (specify below)

Git commit hash (if applicable)

No response

If applicable, where did you install Barrier from?

No response

What OSes are you seeing the problem on? (Check all that apply)

Linux

What OS versions are you using?

openSUSE Tumbleweed

Relevant log output

No response

Any other information

No response

[p12tic]

The release tarball by definition does not include external projects that we reference by git modules for convenience.

Having said that I agree that it makes sense to ship barrier-x.y.z-vendored.tar.gz for the cases where vendored code is not a problem.

[simotek]

Ahh easy then, we have nothing currently providing gulrak in openSUSE so I was going to bundle it atleast for now to get the security updates out. we use the system gmock etc so thats never been an issue

[presire]

On my SLE15 SP3 and openSUSE Leap 15.3, I installed it (tarball) by following the steps below.

1. First, download the source code for gmock, gtest, gulrak-filesystem.
   

// for gmock, gtest
git clone https://github.com/google/googletest.git

// for gulrak-filesystem
git clone https://github.com/gulrak/filesystem

2. Copy the source code needed to build Barrier into the "ext/gmock", "ext/gtest", "ext/gulrak-filesystem" directory in the Barrier directory.
   

cp -r googletest/googlemock/* <Barrier Directory>/ext/gmock
cp -r googletest/googletest/* <Barrier Directory>/ext/gtest
cp -r filesystem/* <Barrier Directory>/ext/gulrak-filesystem

3. Build and install Barrier.
   

cd <Barrier Directory> && mkdir build && cd build
cmake -DCMAKE_INSTALL_PREFIX=${HOME}/Barrier -DCMAKE_BUILD_TYPE=Release ..
make -j $(nproc)
make install