DBZ-6320 Fix Cassandra3 build to work with JDK names sans dots. #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The most recent JDK 20 version string is simply "20" and the jamm dependency bundled with cassandra-all does not support version strings that may not contain dots, basically it only supports JDK 8 or earlier. Bumping to 0.3.3 supports dot and non-dot named version strings.
|
what about cassandra 4 and dse module? All good there? |
jpechane
reviewed
Apr 11, 2023
cassandra-3/pom.xml
Outdated
| <dependency> | ||
| <groupId>com.github.jbellis</groupId> | ||
| <artifactId>jamm</artifactId> | ||
| <version>0.3.3</version> |
There was a problem hiding this comment.
Should not this go into BOM instead?
There was a problem hiding this comment.
I choose not to do that because the only one I wanted to override was cassandra 3 as the other two modules are unaffected. If you want it defined in the BOM I can do that, just let me know.
The dependency version used by Cassandra 4 and DSE are fine, they're based on 0.3.2 or later which isn't affected by the problem. |
smiklosovic
approved these changes
Apr 11, 2023
|
@Naros Applied, thanks. I just changed the POM to use dependency management for version resolution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/DBZ-6320
The most recent JDK 20 version string is simply "20" and the jamm dependency bundled with cassandra-all does not support version strings that may not contain dots, basically it only supports JDK 8 or earlier. Bumping to 0.3.3 supports dot and non-dot named version strings.
@jpechane This should fix the Java Outreach failures with JDK20 for Cassandra builds.