Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBZ-7618 Prevent multiple calls to pu.maxTimestamp() #124

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

samssh
Copy link
Contributor

@samssh samssh commented Mar 11, 2024

Invoking the pu.maxTimestamp() function within the handleRowModifications method, which is inside a loop in handleRowIterator, can lead to performance issues and significantly slow down the connector.

@samssh
Copy link
Contributor Author

samssh commented Mar 11, 2024

Copy link

Welcome as a new contributor to Debezium, @samssh. Reviewers, please add missing author name(s) and alias name(s) to the COPYRIGHT.txt and Aliases.txt respectively.

@jpechane jpechane merged commit ca0cd55 into debezium:main Mar 12, 2024
2 of 4 checks passed
@jpechane
Copy link
Contributor

@samssh Applied, thanks!

@samssh samssh deleted the DBZ-7622 branch March 12, 2024 07:18
@Ficooooooo
Copy link

Invoking the pu.maxTimestamp() function within the handleRowModifications method, which is inside a loop in handleRowIterator, can lead to performance issues and significantly slow down the connector.

Hi @samssh, I've encountered with performance issue as well, and I've test performance of 2.5.3.Final, it seems like there is no difference on performance when reading the commit log files, did I use the wrong version or I need to change some configurations?

And based on your test, is the problem fixed?

@samssh
Copy link
Contributor Author

samssh commented Apr 3, 2024

Invoking the pu.maxTimestamp() function within the handleRowModifications method, which is inside a loop in handleRowIterator, can lead to performance issues and significantly slow down the connector.

Hi @samssh, I've encountered with performance issue as well, and I've test performance of 2.5.3.Final, it seems like there is no difference on performance when reading the commit log files, did I use the wrong version or I need to change some configurations?

And based on your test, is the problem fixed?

Hi @Ficooooooo. I answered your question here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants