Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBZ-6862 Skip tombstone events #32

Merged
merged 5 commits into from
Sep 5, 2023
Merged

DBZ-6862 Skip tombstone events #32

merged 5 commits into from
Sep 5, 2023

Conversation

mfvitale
Copy link
Member

@mfvitale mfvitale commented Sep 1, 2023

@mfvitale mfvitale force-pushed the DBZ-6862 branch 3 times, most recently from e019a27 to bf284e0 Compare September 4, 2023 09:43
@mfvitale mfvitale requested a review from Naros September 4, 2023 10:24
@@ -69,6 +69,11 @@ public void execute(SinkRecord record) {
.withDialect(dialect)
.build();

if (descriptor.isTombstone()) {
LOGGER.debug("Skipping tombstone record {}", descriptor);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a small commit to change this from info to debug.

Copy link
Member

@Naros Naros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @mfvitale !

@Naros Naros merged commit 96868c1 into debezium:main Sep 5, 2023
7 checks passed
@Naros
Copy link
Member

Naros commented Sep 5, 2023

Applied to main (=2.4).

@mfvitale mfvitale deleted the DBZ-6862 branch October 4, 2023 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants