DBZ-6510 Use event processing failure handling mode in VitessReplicationConnection #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @twthorn, thanks for your contribution. Please prefix the commit message(s) with the DBZ-xxx JIRA issue key. |
jpechane
requested changes
Jun 1, 2023
| @@ -175,6 +175,15 @@ public static BigIntUnsignedHandlingMode parse(String value, String defaultValue | |||
| } | |||
| } | |||
|
|
|||
| public EventProcessingFailureHandlingMode getEventProcessingFailureHandlingMode() { | |||
There was a problem hiding this comment.
This should be unnecessary as io.debezium.config.CommonConnectorConfig.EVENT_PROCESSING_FAILURE_HANDLING_MODE declares FAIL as the default value.
| consumedMessages.add(new MessageAndVgtid(message, vgtid)); | ||
| }, | ||
| error); | ||
| // Since we are using the "current" as the starting position, there is a race here |
There was a problem hiding this comment.
This is a bit unsafe. Could you please take a look at io.debezium.connector.mysql.StreamingSourceIT.inconsistentSchema(EventProcessingFailureHandlingMode) to see how to intercept log messages and wait for them?
|
@jpechane Thank you for the review. I've updated with the feedback to refactor the test to wait on log messages, and to remove the unnecessary config method. |
|
@twthorn Applied, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use the event processing failure handling mode for handling errors appropriately in the VitessReplicationConnection. This is similar to what is done for Postgres. We follow the standard behaviors for error/skip/warn/ignore.
Verification
Add a few integration tests for each branch of error/skip/warn/ignore. Check that the error throwable is set/not set appropriately. Use the example use case of an oversized grpc message to be the guaranteed failure (by setting byte max very low).