This repository has been archived by the owner on Nov 18, 2021. It is now read-only.
DBZ-3055 Capture table state when LogMiner session fails #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gunnarmorling
approved these changes
Feb 4, 2021
There was a problem hiding this comment.
LGTM. One question inline, no blocker.
@jpechane, can you include this for the relase?
| * @throws SQLException thrown if an exception occurs performing a SQL operation | ||
| */ | ||
| private static void logQueryResults(Connection connection, String query) throws SQLException { | ||
| try (PreparedStatement s = connection.prepareStatement(query); ResultSet rs = s.executeQuery()) { |
There was a problem hiding this comment.
Would it help to use one of the utility methods on JdbcConnection?
There was a problem hiding this comment.
Adjusted the API to pass in OracleConnection so we could access those methods. I'll add making sure we align to using that class primarily for connection operations as it relates to LogMinerHelper in DBZ-2552.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/DBZ-3055