Skip to content
This repository has been archived by the owner on Nov 18, 2021. It is now read-only.

DBZ-3154 Update test suite to run in CDB & non-CDB modes. #278

Merged
merged 3 commits into from Mar 2, 2021
Merged

DBZ-3154 Update test suite to run in CDB & non-CDB modes. #278

merged 3 commits into from Mar 2, 2021

Conversation

Naros
Copy link
Member

@Naros Naros commented Mar 2, 2021 •
edited

https://issues.redhat.com/browse/DBZ-3154

This should be merged in conjunction with debezium/oracle-vagrant-box#18 as the changes in the helper class reflects the various script changes in the vagrant box repository.

gunnarmorling
gunnarmorling reviewed Mar 2, 2021
View reviewed changes
Copy link
Member

@gunnarmorling gunnarmorling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Naros, two comments inline. Also, how does the test suite gets run with CDB vs. PDB modes? Is some update to the README due? Or even update to CI config to test both modes? // CC @jpechane

debezium-connector-oracle/src/main/java/io/debezium/connector/oracle/OracleConnectorConfig.java Outdated Show resolved Hide resolved
debezium-connector-oracle/src/main/java/io/debezium/connector/oracle/OracleConnectorConfig.java Outdated Show resolved Hide resolved
gunnarmorling
gunnarmorling reviewed Mar 2, 2021
View reviewed changes
Copy link
Member

@gunnarmorling gunnarmorling left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Naros one follow-up :) And any comments on my other questions (README, CI)?

debezium-connector-oracle/src/test/java/io/debezium/connector/oracle/logminer/SqlUtilsTest.java Outdated Show resolved Hide resolved
@Naros
Copy link
Member Author

Naros commented Mar 2, 2021

Also, how does the test suite gets run with CDB vs. PDB modes? Is some update to the README due? Or even update to CI config to test both modes?

So the way to test the connector in CDB mode is just to run the test suite as you normally would. If you provide the test suite with a database.pdb.name parameter with a non-empty value or if you don't specify this setting, the test suite will assume that it is in CDB mode just like it always had. The caveat with the test suite is that if you specify database.pdb.name but with an empty value, the test suite has a special handling of this use case to trigger non-CDB mode.

That said, I'll add a note in the README that describes this as well.

gunnarmorling
gunnarmorling reviewed Mar 2, 2021
View reviewed changes
debezium-connector-oracle/src/main/java/io/debezium/connector/oracle/OracleConnectorConfig.java
@@ -725,7 +727,7 @@ public boolean isIncluded(TableId t) {
}

private boolean isExcludedSchema(TableId id) {
return Arrays.stream(EXCLUDED_SCHEMAS).anyMatch(id.schema().toLowerCase()::equals);
return EXCLUDED_SCHEMAS.contains(id.schema().toLowerCase());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :)

@gunnarmorling gunnarmorling merged commit 3dd0626 into debezium:master Mar 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gunnarmorling gunnarmorling gunnarmorling approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Naros @gunnarmorling