DBZ-7155 Add Unit Tests for ServiceAccountDependent Class #26
Conversation
|
hi @jcechace, Could you please take a look on this PR to add unittests on the ServiceAccountDependent class. Thank you |
ilyasahsan123
changed the title
ilyasahsan123
force-pushed
the
DBZ-TBA
branch
3 times, most recently
from
727b91f
to
420eb8a
Compare
ilyasahsan123
changed the title
| } | ||
|
|
||
| @Test | ||
| void shouldReturnManagerServiceAccount() { |
There was a problem hiding this comment.
@ilyasahsan123 this should probably read shouldReturnManagedServiceAccount
| ServiceAccount serviceAccount = serviceAccountDependent.desired(debeziumServer, context); | ||
|
|
||
| assertThat(serviceAccount.getMetadata().getName()).isEqualTo(managedSaName); | ||
| assertThat(serviceAccount.getMetadata().getNamespace()).isEqualTo("default"); |
There was a problem hiding this comment.
default is the default so IMHO it might be best to change the namespace first and tests with that.
| } | ||
|
|
||
| @Test | ||
| void shouldDesiredServiceAccount() { |
There was a problem hiding this comment.
Likely should read shouldReturnDesiredServiceAccount
ilyasahsan123
force-pushed
the
DBZ-TBA
branch
2 times, most recently
from
07016f7
to
c68d2cd
Compare
|
|
||
| @AfterEach | ||
| void after() { | ||
| client.resource(debeziumServer).delete(); |
There was a problem hiding this comment.
@ilyasahsan123 since this is a unit test we are not really creating the object within kubernetes (we shouldn't). So I don't think this is required. Consequently the client field itself is not required.
| private final String dsName = "test-ds"; | ||
| private final String saName = "test-ds-service-account"; | ||
| private final String managedSaName = "test-ds-sa"; | ||
| private final String namespace = "debezium"; |
ilyasahsan123
force-pushed
the
DBZ-TBA
branch
from
c68d2cd
to
77e5a99
Compare
| private final String managedSaName = "test-ds-sa"; | ||
| private final String namespace = "debezium"; |
There was a problem hiding this comment.
Great. Just convert these two into constants (e.g. private static final String MANAGED_SA_NAME) and I will merge it.
add end of lines Reformat the file Fix the failed CI by sorting the imports. Fix the failed CI by adding Class header. Implement Suggestion from peer review refactor the code Remove Kubernetes Client Rename constant variables
ilyasahsan123
force-pushed
the
DBZ-TBA
branch
from
77e5a99
to
d380815
Compare
https://issues.redhat.com/browse/DBZ-7155