Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DBZ-7267 Create Unittest Class for VersionProvider Class #33

Merged
merged 1 commit into from
Dec 19, 2023
Merged

DBZ-7267 Create Unittest Class for VersionProvider Class #33

merged 1 commit into from
Dec 19, 2023

Conversation

ilyasahsan123
Copy link
Contributor

@ilyasahsan123
Copy link
Contributor Author

hi @jcechace,

I am wondering, is it necessary for line 36 on VersionProvider class?

https://github.com/debezium/debezium-operator/blob/main/debezium-operator-core/src/main/java/io/debezium/operator/core/VersionProvider.java#L36

The reason is I can't create unittest for it and impacting coverage is not 100%

image

Thanks

@jcechace
Copy link
Member

@ilyasahsan123 Not exactly sure what you mean. But one case is missing -- a non snapshot version. so E.g. 2.5.0

@jcechace
Copy link
Member

otherwise it's OK to be included.

@ilyasahsan123
DBZ-7267 Create Unittest Class for VersionProvider Class
81ca49c 
add test for shouldReturnImageVersion

optimize the code

fix format
@ilyasahsan123
Copy link
Contributor Author

@ilyasahsan123 Not exactly sure what you mean. But one case is missing -- a non snapshot version. so E.g. 2.5.0

Never mind. I thought the value of fullVersion is will always imageVersion.substring(0, imageVersion.length() - SNAPSHOT.length() - 1) 🤔

Anyway, I have added the test for a non snapshot version. so E.g. 2.5.0

Kindly need your take another look.

Thank you

@ilyasahsan123
Copy link
Contributor Author

hi @jcechace ,

I just want to friendly reminder for this. Do you still have any concern?

Thanks

@jcechace jcechace merged commit 3287f98 into debezium:main Dec 19, 2023
2 checks passed
@jcechace
Copy link
Member

@ilyasahsan123 Thanks for the contribution. Merged.

PS: Had to address some last minute issues with the upcoming 2.5. release yesterday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@ilyasahsan123 @jcechace