DBZ-6461 Debezium Server cannot recover from Google Pub/Sub errors #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n.timeout.ms` and `debezium.sink.pubsublite.wait.message.computation.timeout.ms` to configure the wait time on message processing by Google PubSub
jpechane
reviewed
May 16, 2023
| @@ -123,6 +125,9 @@ public interface PublisherBuilder { | |||
| @ConfigProperty(name = PROP_PREFIX + "retry.rpc.timeout.multiplier", defaultValue = "2.0") | |||
| Double rpcTimeoutMultiplier; | |||
|
|
|||
| @ConfigProperty(name = PROP_PREFIX + "wait.message.computation.timeout.ms", defaultValue = "5000") | |||
There was a problem hiding this comment.
@mfvitale We are going from unlimited. It is really hard to know what is the usual time till the mesage batch is written.
Is not 5 secs value a bit too aggressive? I'd prefer to err on the safe side at least in the beginning and choose 30 or 60 secs.
Also why computation? Would not delivery be better to represent the value use?
|
@mfvitale Applied, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add properties
debezium.sink.pubsub.wait.message.computation.timeout.msanddebezium.sink.pubsublite.wait.message.computation.timeout.msto configure the wait time on message processing by Google PubSub. In this wait the connector can fail and be restarted.
Doc PR debezium/debezium#4544