Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dbz 4146 #399

Merged
merged 5 commits into from Nov 8, 2021
Merged

Dbz 4146 #399

merged 5 commits into from Nov 8, 2021

Conversation

indraraj
Copy link
Member

@indraraj indraraj commented Oct 21, 2021

https://issues.redhat.com/browse/DBZ-4146

Using backend response to fetch the SMT list and their properties.

@indraraj indraraj requested a review from uidoyen October 21, 2021 09:26
@indraraj indraraj added the Do not merge Some required work isn't there label Oct 21, 2021
@indraraj
Copy link
Member Author

Backend API need to be fixed first.

@indraraj indraraj removed the Do not merge Some required work isn't there label Nov 3, 2021
@indraraj
Copy link
Member Author

indraraj commented Nov 3, 2021

Backend End point fixed, it's good to go.

@mdrillin
Copy link
Member

mdrillin commented Nov 3, 2021

@indraraj - I'm seeing a couple issues while testing this. Are you seeing the same?

  1. Add a transformation. The first time I select a transformation type, I get the following console warning:

react-dom.development.js?a814:67 Warning: Received the string true for the boolean attribute checked. Although this works, it will not work as expected if you pass the string "false". Did you mean checked={true}?
at input
at div
at Checkbox (webpack-internal:///../../node_modules/@patternfly/react-core/dist/esm/components/Checkbox/Checkbox.js:19:9)
at div
at SplitItem (webpack-internal:///../../node_modules/@patternfly/react-core/dist/esm/layouts/Split/SplitItem.js:16:11)
at div
at Split (webpack-internal:///../../node_modules/@patternfly/react-core/dist/esm/layouts/Split/Split.js:16:11)
at FormCheckboxComponent (webpack-internal:///./src/app/components/formHelpers/FormCheckboxComponent.tsx:22:108)
...

  1. After adding a transformation, click apply. Then click next to next page. Then click 'back' to go back to SMT page. Get the following error:

TransformsStep.tsx?f72a:55 Uncaught TypeError: response.forEach is not a function
at getOptions (TransformsStep.tsx?f72a:55)
at eval (TransformsStep.tsx?f72a:319)
at Array.map ()
at Object.eval [as children] (TransformsStep.tsx?f72a:304)
at WithLoader.render (WithLoader.tsx?e511:98)
at finishClassComponent (react-dom.development.js?a814:17485)
at updateClassComponent (react-dom.development.js?a814:17435)
at beginWork (react-dom.development.js?a814:19073)
at HTMLUnknownElement.callCallback (react-dom.development.js?a814:3945)
at Object.invokeGuardedCallbackDev (react-dom.development.js?a814:3994)
getOptions @ TransformsStep.tsx?f72a:55
eval @ TransformsStep.tsx?f72a:319
eval @ TransformsStep.tsx?f72a:304
WithLoader.render @ WithLoader.tsx?e511:98
...

@indraraj
Copy link
Member Author

indraraj commented Nov 8, 2021

Hey @mdrillin for the first points looks like its backend response issue for the type boolean default value is coming as "true"

defaultValue: "true"
title: "Add source topic name into key"
type: "BOOLEAN"
x-name: "key.enforce.uniqueness"

Fixed second issue.

Copy link
Member

@mdrillin mdrillin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thanks!

@mdrillin mdrillin merged commit a50ff96 into debezium:main Nov 8, 2021
@indraraj indraraj deleted the DBZ-4146 branch January 24, 2022 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants