Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creating dynamic form using ConnectorProperty #60

Merged
merged 4 commits into from
Sep 9, 2020
Merged

Creating dynamic form using ConnectorProperty #60

merged 4 commits into from
Sep 9, 2020

Conversation

uidoyen
Copy link
Member

@uidoyen uidoyen commented Sep 8, 2020

  • Created dynamic form using connector properties
  • Upgraded Formik
  • Added Switch Component
  • Added Formik to nohoist

mdrillin
mdrillin reviewed Sep 8, 2020
View reviewed changes
ui/packages/ui/src/app/pages/createConnector/CreateConnectorPage.tsx Outdated
@@ -147,6 +147,7 @@ export const CreateConnectorPage: React.FunctionComponent = () => {
propertyValues: Map<string, string>,
category: PropertyCategory
): void => {
console.log(propertyValues)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove the console.log

mdrillin
mdrillin approved these changes Sep 8, 2020
View reviewed changes
Copy link
Member

@mdrillin mdrillin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with your changes. console.log was giving a build error - pls remove that then you can merge it.

indraraj
indraraj approved these changes Sep 8, 2020
View reviewed changes
Copy link
Member

@indraraj indraraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one suggestion in the tslint.json file rest looks good to me.

ui/packages/ui/tslint.json Outdated
@@ -7,6 +7,7 @@
},
"rules": {
"jsx-no-lambda": false,
"ordered-imports": false,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could leave the ordered-import true, as vscode(lint plugins) itself provides a one-click fix for it.

@uidoyen uidoyen merged commit aae9c23 into debezium:master Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdrillin mdrillin mdrillin approved these changes

@indraraj indraraj indraraj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@uidoyen @mdrillin @indraraj