Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abhi.add basic auth kafka connect api #629

Conversation

abhishekkh
Copy link

No description provided.

@github-actions
Copy link

Hi @abhishekkh, thanks for your contribution. Please prefix the commit message(s) with the DBZ-xxx JIRA issue key.

@abhishekkh
Copy link
Author

abhishekkh commented Jul 13, 2022

Deleted the tf plan

@indraraj
Copy link
Member

Hey @rk3rn3r, can you have a look at this one.

@rk3rn3r
Copy link
Member

rk3rn3r commented Jul 19, 2022

Hello @abhishekkh, first of all thank you for the contribution. Is there a Jira issue for this PR in the Red Hat issue tracker?
If so, could you please prefix your commit messages and the PR title with the task id (like DBZ-1234)?
What is that QA plan comment above? Is this relevant for the PR?

What is the reason for removing the "Create Connector" button? Is this on purpose? Is that valid @indraraj?

@abhishekkh
Copy link
Author

@rk3rn3r @indraraj Haven't raised a ticket yet, I have forked and pushed this image to our private ECR.

The create button was removed as we didn't want users to create new connectors in prod without performing capacity analysis for the pods we already have in the cluster. It would be nice if we can have some ACLs that can control the operations that can be performed based on role assigned using okta etc. I also plan to remove the delete button.

Since I have your attention, is there a way to hide the sasl.jaas.config in the connector details, similar to the database password? Asked this question on zulip chat as well.

  • typed from my phone

@rk3rn3r
Copy link
Member

rk3rn3r commented Jul 28, 2022

Hey @abhishekkh! Do you really want to make a PR or did you only require a branch for your local env? I am closing this one as 1) there's no config option for switching to basic auth, even this feels like an interesting addition. We might add this to the Debezium UI later in a separate PR. @indraraj could you maybe file a task for that?
2) we won't remove the create button.
I am closing this PR now. Feel free to open a new PR with dedicated changes when you want them merged into the main repo.

@rk3rn3r rk3rn3r closed this Jul 28, 2022
@abhishekkh
Copy link
Author

Sure that works

@rk3rn3r
Copy link
Member

rk3rn3r commented Jul 29, 2022

@abhishekkh I just filed DBZ-5459 to add some config options for customizing the Debezium UI. One subtask is the removal of the "Create Connector" button.
We might provide this with another deployment mode like "view_only" or something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants