DBZ-6540 Blogpost about custom signalling/notification channels - part1 #919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Naros can I gently ask to take a look? |
|
🎊 PR Preview has been successfully built and deployed to https://debezium-debezium-github-io-preview-pr-919.surge.sh
|
Naros
reviewed
Jun 16, 2023
There was a problem hiding this comment.
Hi @mfvitale this is an excellent write-up thus far, despite my red marker suggestions below. Most of these edits are primarily just clean-up or formalities, nothing serious.
My only suggestion aside from the below is moving forward, let's focus on keeping the style in .adoc files where each line corresponds to a single sentence at max. I know sometimes Bob deviates from this in the docs, and I try to catch this, but it's just a formal style we adopted long ago, and I just want to remain consistent.
Co-authored-by: Chris Cranford <ccranfor@redhat.com>
Naros
approved these changes
Jun 22, 2023
|
@jpechane Do you think can be published now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the part 1 of 3 about signaling and notification.