Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBZ-115 Add support to recognize older row_event formats #115

Merged
merged 1 commit into from Oct 8, 2016

Conversation

williecheong
Copy link
Contributor

@williecheong williecheong commented Oct 8, 2016

Reason for this pull request is because of the following error:

2016-10-07 22:47:31,575 TRACE  MySQL|my_williedb|binlog  Ignoring event due to missing handler: Event{header=EventHeaderV4{timestamp=1475873147000, eventType=UPDATE_ROWS, serverId=1, headerLength=19, dataLength=117, nextPosition=1120, flags=0}, data=UpdateRowsEventData{tableId=748, includedColumnsBeforeUpdate={0, 1, 2, 3, 4, 5, 6, 7, 8, 9}, includedColumns={0, 1, 2, 3, 4, 5, 6, 7, 8, 9}, rows=[
    {before=[16192792, 12, 34227952, 10, 8, 0, 1109399502, 2016-06-25T17:55:33Z, 2016-10-07T20:23:48.472583Z, 0], after=[16192792, 12, 34227952, 10, 8, 0, 1109459289, 2016-06-25T17:55:33Z, 2016-10-07T20:45:47.985929Z, 0]}
]}}   [io.debezium.connector.mysql.BinlogReader]

The binlog reader does not recognize any EventType with prior row_event versions in the handler map, and is ignoring those entries as a result. Adding these row_event EventType to the eventHandler map should resolve the problem.

@williecheong
Copy link
Contributor Author

Hey @rhauch can you review / approve this mini pull request and include it in the upcoming 0.33 release? Thanks!

@rhauch
Copy link
Member

rhauch commented Oct 8, 2016

@williecheong Thanks for diagnosing and submitting this fix.

The project does require commit messages include the JIRA issue number so that it's easier to correlate past changes with more thorough issue descriptions and discussions. (We do make exceptions for trivial changes or changes to documentation.) I could fix that, but doing so means losing your authorship in the commit history, which I would very much prefer to keep.

Can you please amend your commit (e.g., git commit --amend) so the description begins with "DBZ-115" (see commit history for examples), then forcibly push the commit to this same branch (e.g, git push origin patch-1 where origin is the local name of your remote fork repo on GitHub)? Then I'd be happy to merge it into the master branch for inclusion in 0.4.0 and cherry-pick to the 0.3.x branch for inclusion in 0.3.3 (which we may release as early as Monday).

@rhauch
Copy link
Member

rhauch commented Oct 8, 2016

I also added comment to DBZ-115 that references this PR, and changed the fix version to be 0.3.3 and 0.4.

@rhauch rhauch changed the title Add support to recognize older row_event formats DBZ-115 Add support to recognize older row_event formats Oct 8, 2016
@williecheong
Copy link
Contributor Author

@rhauch Great! Thanks for the quick response.
An early merge into 0.3.3 will be much appreciated.
The commit message has now been amended to reflect issue DBZ-115.

Happy to join the family of contributors here at debezium.

@rhauch rhauch merged commit ee3277d into debezium:master Oct 8, 2016
@williecheong williecheong deleted the patch-1 branch October 13, 2016 23:30
@williecheong
Copy link
Contributor Author

hey @rhauch, I see that there is one more blocker issue with a pull request under review. Any estimate on the release date of v0.3.3 ?

@rhauch
Copy link
Member

rhauch commented Oct 14, 2016

ATM 0.3.3 is being blocked by DBZ-129.

bdbene pushed a commit to bdbene/debezium that referenced this pull request Jun 23, 2023
bdbene pushed a commit to bdbene/debezium that referenced this pull request Jun 23, 2023
methodmissing pushed a commit to methodmissing/debezium that referenced this pull request Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants