DBZ-146 Improved error handling of MySQL Connector #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
criccomini
reviewed
Nov 2, 2016
| @@ -387,6 +386,15 @@ protected void handleGtidEvent(Event event) { | |||
| protected void handleQueryEvent(Event event) { | |||
| QueryEventData command = unwrapData(event); | |||
| logger.debug("Received update table command: {}", event); | |||
| String sql = command.getSql().trim(); | |||
| if ( sql.equalsIgnoreCase("BEGIN") ) { | |||
| @@ -296,6 +287,14 @@ protected void handleEvent(Event event) { | |||
|
|
|||
| // And after that event has been processed, always set the starting row number to 0 ... | |||
| startingRowNumber = 0; | |||
| } catch (RuntimeException e) { | |||
| // There was an error in the event handler, so propagate the failure to Kafka Connect ... | |||
| failed(e,"Error processing binlog event"); | |||
| stop(); | ||
| } catch (Throwable s) { | ||
| // Log, but don't propagate ... | ||
| logger.error("Failed to start the connector (see other exception), but got this error while cleaning up",s); |
Improved the error handling of the MySQL connector to ensure that we’re always stopping the connector when we have a problem handling a binlog event or if we have problems starting.
|
Rebased and corrected the formatting issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved the error handling of the MySQL connector to ensure that we’re always stopping the connector when we have a problem handling a binlog event or if we have problems starting.