DBZ-2418 More meaningful error message in case of incorrect credentials #1748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is called only once anyways, so there's no need for storing the info in a field in PostgresConnection. This allows PostgresConnector#validate() bring up a more meaningful error message in case of incorrect credentials and other incorrect connection configuration.
jpechane
approved these changes
Aug 12, 2020
There was a problem hiding this comment.
@gunnarmorling LGTM, you can merge it. I just recommend a last check and that's priming of TypeRegistry. It can genereate SQL error too but from my reading of the code the connection is validated before a connection that requires type registry is created. But better to doublecheck.
|
Yes, right. The type registry will only be required when getting a connection from with the task class. Whereas validate() on the connector class is called before that. Not sure about embedded / DBZ Server, though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/DBZ-2418