DBZ-2049 Add deployment steps to the doc for each connector #1801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TovaCohen
force-pushed
the
DBZ-2049-deploy-instructions
branch
from
c38886a
to
1a852e7
Compare
|
Note that for the Db2, MySQL, and SQL Server connector doc, I also changed the format that explains the connector configuration settings. For those connectors only, the rendered downstream user guide had duplicated callout number in the explanatory text below the code samples. I tried many things to fix this, with no luck. So I removed the problem text and replaced it with a table. |
…n Gunnar's comments
TovaCohen
force-pushed
the
DBZ-2049-deploy-instructions
branch
from
1a852e7
to
eec5719
Compare
Naros
reviewed
Sep 11, 2020
|
LGTM, merged to master and branch 1.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These updates are for DBZ-2049.
I used the deployment instructions that we updated in the PostgreSQL connector doc as the model to update and add deployment instructions for each connector.
There is a separate commit for the updates in each connector.
I manually copied the updated files downstream to make sure that the downstream book builds. You might notice a few updates that seem unrelated to this update, but I had to make them to get the book to build.
In the PostgreSQL connector doc, I updated a link target URL.
I confirmed that Antora builds the doc.
These updates are not required for 1.2, but it would be nice to be able to provide them in the downstream 1.2 doc.
Let me know what needs to change.