DBZ-2544 Fix test failure - PostgresConnectorIT#customSnapshotterSkipsTablesOnRestart #1854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's a formatting glitch it seems. |
|
Ah my fault for being too hasted with my fix; it should be fixed now. |
|
A green one. It feels as if things are getting more stable... Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/DBZ-2544
As some background, I think the underlying problem here is that we previously double dipped on the database check. While locally testing, when the test would fail showed some metadata queries that the connector wasn't issuing but seemed to be coming from the JDBC driver itself. Because of how we asserted the state, I think this is what lead to the inconsistent pass/fail of this test.
This PR instead changes the behavior to rely solely on the
AwaitilityAPI call and if that results in a time-out, we fail the test. If that call results in success, that should be sufficient to allow the test to pass without the additional query & assertion check.