DRAFT: DBZ-190 Proposed changes to explicitly set a null default on optional field schemas #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhauch
changed the title
|
Closing without merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At this time, this should not be merged!
Having to explicitly call
SchemaBuilder'sdefaultValue(null)everywhere we have an optional schema is really painful, but this PR contains all of the places where this would have to be done. But per my comment on [DBZ-190|https://issues.jboss.org/browse/DBZ-190], this still won't have any affect on the Avro schema generated by the {{AvroConverter}}.