Only set filter info in offsets when snapshot.new.tables = parallel #1875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
LGTM, but I'm not super-deep into the parallel implementation. @mtagle, any thoughts on this one from you perhaps? Thanks a lot!
|
LGTM! This was always the intention but I missed the case where parallel snapshotting would be turned off. |
|
@johnjmartin Applied, thanks. @mtagle Thanks for the review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://issues.redhat.com/browse/DBZ-2643
This PR adds a check to
maybeSetFilterDataFromConfigfor the case where a connector has filter info, but snapshot.new.tables is not set to parallel. In this case we unset the filters.I'm also updating the
MySQLConnectorTaskto runmaybeSetFilterDataFromConfigin every case where it's picking up from an existing offset, rather than only running the update when offsets are missing filter info.I've tested this change in our staging environment.