DBZ-3271 Unifying filter handling across relational connectors #2211
Conversation
| * | ||
| * @author Gunnar Morling | ||
| */ | ||
| public enum ColumnFilterMode { |
There was a problem hiding this comment.
Could you please rrename this class and generalize it? I can envision it will not be used only for column filters but another use case too - e.g. https://issues.redhat.com/browse/DBZ-3244
Also could you add one more mode - FULL that would requrie all three components? Albeit not needed now with multiple datbases support it will be the naturally needed.
There was a problem hiding this comment.
Can we do those changes when we actually need them? I'm a bit reluctant to build something "just in case", without knowing what actually is required. We can easily refactor this once the demand is there.
| private final TemporalPrecisionMode temporalPrecisionMode; | ||
| private final KeyMapper keyMapper; | ||
| private final TableIdToStringMapper tableIdMapper; | ||
|
|
||
| protected RelationalDatabaseConnectorConfig(Configuration config, String logicalName, TableFilter systemTablesFilter, | ||
| TableIdToStringMapper tableIdMapper, int defaultSnapshotFetchSize) { | ||
| TableIdToStringMapper tableIdMapper, int defaultSnapshotFetchSize, | ||
| ColumnFilterMode columnFilterMode) { |
There was a problem hiding this comment.
I feel we are proliferating consturctor params too much. Can't the connector expose a method like columnFilterMode() so it wouldn't be necessary to pass the param? Also SCHEMA will be the default one and CATALOG will be override for two connectors.
There was a problem hiding this comment.
Hum, hum. I'm not a fan of the method approach, as it's another method exposed on the API surface of RelationalDatabaseConnectorConfig and could be called by other classes (which it shouldn't). How about I add another constructor without the parameter, which does the defaulting to SCHEMA?
https://issues.redhat.com/browse/DBZ-3271
Accompanied by these PRs in downstream repos: