DBZ-232 Removed the database and table name recommenders #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It’s not clear how valuable these recommenders actually are. First, it’s not clear about the expected semantics: can the user use values that don’t appear in the recommended values? Second, the recommenders that return large numbers of values can be slow and can result in very large REST API responses. Debezium was using recommenders to return the database and table/collection names, but these lists can be very large for large databases. Rather than cap the number of recommended values and have the recommender return a subset of all potential values, we will instead remove the recommenders altogether.
| @@ -295,11 +287,10 @@ public static SecureConnectionMode parse(String value, String defaultValue) { | |||
| } | |||
| } | |||
|
|
|||
| private static final int RECOMMENDER_LIMIT = 100; | |||
There was a problem hiding this comment.
That seems to be a left-over from the first commit. I'll remove it.
|
Rebased and applied. Thanks, @rhauch. Added one more commit for removing the unused constant, too. |
methodmissing
added a commit
to methodmissing/debezium
that referenced
this pull request
Apr 6, 2024
* Rebuild in order to get latest cert_checker from CDC (debezium#220) * Add the Pyroscope jar as a dependency * Reference the correct pyroscope agent artefact * Oust spurious tailing argument --------- Co-authored-by: Dave Sugden <dave.sugden@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It’s not clear how valuable these recommenders actually are. First, it’s not clear about the expected semantics: can the user use values that don’t appear in the recommended values? Second, the recommenders that return large numbers of values can be slow and can result in very large REST API responses.
Debezium was using recommenders to return the database and table/collection names, but these lists can be very large for large databases. Rather than cap the number of recommended values and have the recommender return a subset of all potential values, we will instead remove the recommenders altogether.