Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DBZ-3572 Binlog metrics were renamed to streaming #2431

Merged
merged 1 commit into from Jun 1, 2021
Merged

DBZ-3572 Binlog metrics were renamed to streaming #2431

merged 1 commit into from Jun 1, 2021

Conversation

jpechane
Copy link
Contributor

@jpechane jpechane commented Jun 1, 2021

https://issues.redhat.com/browse/DBZ-3572

Needs to be backported to 1.5 branch

gunnarmorling
gunnarmorling approved these changes Jun 1, 2021
View reviewed changes
Copy link
Member

@gunnarmorling gunnarmorling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a slight compatibility concern here, but I think that's acceptable. Let's just make sure to point it out in the upgrade notes. Btw. what's the name when enabling the legacy impl, the old one?

@gunnarmorling gunnarmorling merged commit 31e1e79 into debezium:master Jun 1, 2021
@gunnarmorling
Copy link
Member

Applied to master (1.6) and 1.5.

@jpechane
Copy link
Contributor Author

jpechane commented Jun 1, 2021

@gunnarmorling Yes, the old one

@gunnarmorling
Copy link
Member

gunnarmorling commented Jun 1, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gunnarmorling gunnarmorling gunnarmorling approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@jpechane @gunnarmorling