DBZ-284 Fix NPE when inserting a NULL in a POINT column #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gunnarmorling
approved these changes
Jun 13, 2017
There was a problem hiding this comment.
Looks good, @omarsmak. I'll fix that one whitespace glitch and merge. Thanks a lot!
| @@ -508,8 +508,13 @@ protected Object convertPoint(Column column, Field fieldDefn, Object data){ | |||
| if (data == null) { | |||
| data = fieldDefn.schema().defaultValue(); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Could you configure your IDE so it removes any trailing whitespace? E.g. there's a "Save action" for that in Eclipse, I'd expect similar options to exist in other IDEs. Avoiding this kind of noise makes it easier for all of us to work with the code, review changes etc. Thanks!
No need to change this very one, though. I'll take care of it prior to merging.
There was a problem hiding this comment.
I am actually wondering about my configuration for my IDE, I am using Intellij IDEA. I will try to to take care of these trailing whitespace in my next PR :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix for DBZ-284 when inserting a
NULLvalue in a column withPOINTdatatype.