DBZ-3824 NoClassDefFoundError for junit platform

[jcechace]

https://issues.redhat.com/browse/DBZ-3824

[jcechace]

Contains also update for junit5 as they did simplify the dependencies lately and surefire/failsafe tend to be sensitive about that.

[gunnarmorling]

@jcechace any idea on the test failures?

[jcechace]

@jcechace any idea on the test failures?

We are correctly tying together versions of Surefire and Failsafe. For whatever reason, it looks like Failsafe is unable to load the entire classpath correctly. I will look into it during the day but I didn't find anything in my brief look yesterday.

[jcechace]

@gunnarmorling I "lowered" the upgrade to surefire and failsafe M4 which seems to solve both issues locally.

[jcechace]

@gunnarmorling the next set of failures appears to be unrelated to changes.

[jcechace]

so the RecordsStreamProducerIT.testEmptyChangesProducesHeartbeat is failing also locally. However at this point I might use some assistance from somebody who knows these test better

[gunnarmorling]

@jcechace, I recommend you get hold of @jpechane on that one :)

[jpechane]

@jcechace See #2590

[gunnarmorling]

@jcechace, could you rebase and force-push this one, so to trigger a new build? Thx!

[jcechace]

@gunnarmorling I did so already yesterday after #2590 was merged. However here you go again ;)

[gunnarmorling]

@jcechace, ok, thx. So I take it the build failures are not related to this change then? Can you work with @jpechane to make sure they are all tracked in Jira? Typically, you should find existing issues by looking for the name of the failing method in question.

[gunnarmorling]

@jpechane, @jcechace, are the last two remaining test failures unrelated and tracked via Jira issues?

[jpechane]

@gunnarmorling Both issues are logged
https://issues.redhat.com/browse/DBZ-3869
https://issues.redhat.com/browse/DBZ-3863

[jcechace]

@gunnarmorling can we merge? I'd like to test if this resolves some test run issues through IntelliJ

[gunnarmorling]

Applied, thx!