DBZ-5256 Add internal.log.mining.transaction.snapshot.boundary.modeoption
#3615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… option This internal option is meant to replace the old `log.mining.query.logs.for.snapshot.offset`. This now enum-based setting provides much more flexibility by being able to completely disable the in-progress transaction check (now the default), only grab transactions that are in-progress from V$TRANSACTION, or finally be able to grab all in-progress transactions that are both from V$TRANSACTION and by scanning the logs.
|
@Naros Applied, very reasonable design, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/DBZ-5256
This internal option is meant to replace the previous internal option
log.mining.query.logs.for.snapshot.offset. This now enum-based setting provides much more flexibility by being able to completely disable the in-progress transaction check, only grab the transactions that are in-progress based on V$TRANSACTION, or to gather all in-progress transactions by scanning the redo logs and inspecting V$TRANSACTION.In addition, for the sake of downstream, I've opted to temporarily enforce SKIP as the default. The option is internal so that if users want to explore this feature they can opt-in to it, but this seems like the most logical way to keep the connector behavior stable.