Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DBZ-2193 Investigate the replacement of LB services with port redirects in OpenShift test-suite #3774

Merged
merged 4 commits into from Dec 13, 2022
Merged

DBZ-2193 Investigate the replacement of LB services with port redirects in OpenShift test-suite #3774

merged 4 commits into from Dec 13, 2022

Conversation

MartinMedek
Copy link
Contributor

No description provided.

@jcechace
Copy link
Member

jcechace commented Aug 5, 2022

Good job as a PoC. Two things which I would like to see

  1. Move the port forwarding into Controller. Ideally into a standalone method which would be called from initialisation method.
  2. The port forwarding should be stopped at the end of the test class -- a teardown method of Fixture class comes to mind as the first place where to put it.

@jcechace jcechace self-requested a review August 5, 2022 14:37
@MartinMedek MartinMedek force-pushed the DBZ-2193 branch 6 times, most recently from cb0a77e to 646e699 Compare August 19, 2022 21:08
@MartinMedek MartinMedek force-pushed the DBZ-2193 branch 3 times, most recently from 7cd28e9 to 7cd43b9 Compare August 25, 2022 11:20
@jcechace
Copy link
Member

@MartinMedek pleas rebase this. It's about time we get this merged. Apology for the delay.

@MartinMedek MartinMedek force-pushed the DBZ-2193 branch 2 times, most recently from 279d875 to b830da9 Compare November 23, 2022 11:38
@MartinMedek MartinMedek marked this pull request as ready for review November 23, 2022 11:42
@MartinMedek MartinMedek marked this pull request as draft November 23, 2022 11:49
@MartinMedek MartinMedek marked this pull request as ready for review November 23, 2022 12:02
@jcechace
Copy link
Member

@obabec should be good to merge once @MartinMedek resolves issues with DB2

@obabec
Copy link
Contributor

obabec commented Dec 5, 2022

@jcechace Martin will also add kafka external listener with route and ssl to this PR.

@MartinMedek MartinMedek force-pushed the DBZ-2193 branch 2 times, most recently from 5ed5984 to 5a687c7 Compare December 10, 2022 10:36
@MartinMedek MartinMedek force-pushed the DBZ-2193 branch 3 times, most recently from 096cbc2 to 6efd76b Compare December 13, 2022 08:09
obabec
obabec approved these changes Dec 13, 2022
View reviewed changes
Copy link
Contributor

@obabec obabec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MartinMedek
DBZ-2193 Refactored testsuite to use port forwarding instead of loadB…
1b3846d 
…alanced services to access DBs
@MartinMedek
DBZ-2193 Created interface for the port forwardble database controlle…
14dbea7 
…r, moved the methods to be called explicitly in test setup and cleanup

Fixed mongo parameters in ConnectorFactories
@MartinMedek
DBZ-2193 replaced kafkaCluster loadBalancer with route, port forward …
1b86333 
…local port is now chosen as first free random port.
@MartinMedek
DBZ-2193 fixed test tags on DockerMongoRhelConnectorIT, removed redun…
f71762e 
…dant test classes, refactor

fixed default sqlserver test parameters in pom
@obabec obabec merged commit de7d84b into debezium:main Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcechace jcechace jcechace requested changes

@obabec obabec obabec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@MartinMedek @jcechace @obabec