Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DBZ-543 Removing a few unused methods #406

Merged
merged 1 commit into from Jan 15, 2018
Merged

DBZ-543 Removing a few unused methods #406

merged 1 commit into from Jan 15, 2018

Conversation

gunnarmorling
Copy link
Member

@gunnarmorling gunnarmorling commented Jan 15, 2018 •
edited

@gunnarmorling
Copy link
Member Author

@jpechane A quick one I noticed while reviewing #396 :)

jpechane
jpechane reviewed Jan 15, 2018
View reviewed changes
debezium-core/src/test/java/io/debezium/data/KeyValueStore.java Outdated
@@ -122,10 +122,6 @@ public Collection getOrCreate(String fullyQualifiedName) {
return getOrCreate(TableId.parse(fullyQualifiedName));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this method used?

@jpechane
Copy link
Contributor

@gunnarmorling Good sight :-). I think I am fine, just maybe one more method can be removed

@gunnarmorling
Copy link
Member Author

@jpechane, ah, yes. Pushed an update.

@jpechane jpechane merged commit b99bdf7 into debezium:master Jan 15, 2018
@jpechane
Copy link
Contributor

Merged, thanks!

@gunnarmorling gunnarmorling deleted the DBZ-543 branch January 18, 2018 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpechane jpechane jpechane left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@gunnarmorling @jpechane